Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added german states, names and cities #17

Merged
merged 8 commits into from May 18, 2011
Merged

Conversation

marvin
Copy link

@marvin marvin commented May 11, 2011

added

  • NameDE with 1000 most popular first_names and over 100 last_names
  • AddressDE including state and city
    -- over 1700 german cities are included
    -- all german states are in AddressDE.state
  • test specs included
  • german phone and street generation to follow

davidnoelte added 8 commits May 11, 2011 10:51
added 100 common german surnames
added NameDE function
fixed NameDE Modules include
added all states of germany
added over 1700 german cities, all special chars have been removed or replaced in city names
@EmmanuelOga
Copy link
Contributor

Wow this is a super comprehensive and clean commit. Txs!

@EmmanuelOga EmmanuelOga reopened this May 18, 2011
EmmanuelOga pushed a commit that referenced this pull request May 18, 2011
added german states, names and cities
@EmmanuelOga EmmanuelOga merged commit a237878 into ffaker:master May 18, 2011
@marvin
Copy link
Author

marvin commented May 19, 2011

no problem. I will integrate some more things soon like more german like address renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants